Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Remove gradle/actions/wrapper-validation because validation is performed by default in gradle/actions/setup-gradle@v4 #491

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

sadv1r
Copy link
Contributor

@sadv1r sadv1r commented Dec 13, 2024

This step is no longer necessary, as setup-gradle@v4 will now handle the same wrapper validation.

From the Build action log of this PR without wrapper-validation:

All Gradle Wrapper jars are valid
  ✓ Found known Gradle Wrapper JAR files:
    2db75c40782f5e8ba1fc278a5574bab070adccb2d21ca5a6e5ed840888448046 gradle/wrapper/gradle-wrapper.jar

…dation is performed by default in gradle/actions/setup-gradle@v4
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.58%. Comparing base (adad639) to head (5414972).
Report is 140 commits behind head on next.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #491   +/-   ##
=======================================
  Coverage   27.58%   27.58%           
=======================================
  Files           4        4           
  Lines          29       29           
=======================================
  Hits            8        8           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsz
Copy link
Member

hsz commented Dec 15, 2024

Thanks, Dmitry!

@hsz hsz merged commit 3740ad9 into JetBrains:next Dec 15, 2024
5 checks passed
@sadv1r sadv1r deleted the wrapperValidationIsIncludedInSetupGradle branch December 16, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants