IDEA-358562 Add error handling for Daemon toolchain #2881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmadalin
force-pushed
the
feature/daemon-toolchain-error-handling
branch
2 times, most recently
from
e2bfcdf to
970dd15
Compare
HackerMadCat
requested changes
Dec 18, 2024
java/idea-ui/src/com/intellij/ide/projectWizard/generators/JdkDownloadService.kt
Show resolved
Hide resolved
plugins/gradle/src/org/jetbrains/plugins/gradle/issue/ConfigurableGradleBuildIssue.kt
Outdated
Show resolved
Hide resolved
...rains/kotlin/idea/gradleJava/issues/checkers/GradleUndefinedDaemonJvmCriteriaIssueChecker.kt
Outdated
Show resolved
Hide resolved
...rains/kotlin/idea/gradleJava/issues/quickfix/GradleAddDownloadToolchainRepositoryQuickFix.kt
Outdated
Show resolved
Hide resolved
...e/src/org/jetbrains/kotlin/idea/gradle/toolchain/GradleDaemonJvmCriteriaDownloadToolchain.kt
Show resolved
Hide resolved
...t/org/jetbrains/kotlin/idea/gradle/toolchain/GradleDaemonJvmCriteriaDownloadToolchainTest.kt
Outdated
Show resolved
Hide resolved
...t/org/jetbrains/kotlin/idea/gradle/toolchain/GradleDaemonJvmCriteriaDownloadToolchainTest.kt
Show resolved
Hide resolved
…nloaded JDK via JdkDownloadService
vmadalin
force-pushed
the
feature/daemon-toolchain-error-handling
branch
2 times, most recently
from
0db4347 to
dfe94d0
Compare
vmadalin
force-pushed
the
feature/daemon-toolchain-error-handling
branch
from
dfe94d0 to
f35915f
Compare
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
… by reusing JdkDownloadService closes #2881 GitOrigin-RevId: 88414f54987aaa3e3cb3fff8d3d34e09bdec966c
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…olchain related exceptions closes #2881 GitOrigin-RevId: eb0794bf807d63379f4801f63106b969aa86fdc6
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
…toolchain related exceptions closes #2881 GitOrigin-RevId: 06410b199410ed8486a36092fd50a7ef3dca611c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
Daemon toolchainwas introduced in Gradle 8.8 and the motivation behind it and other technical details can be found on the public spec document. This PR adds error handling to related exceptions in order to improve the user experience. The implementation follows the agreed details on spec document and UI/UX documentNOTE: The
BuildIssueare parsing errors fromauto-detectionDaemon toolchain but also incoming auto-provisioning support which is expected to land in8.12Tasks
Tests
Demo
Before
After
Screen.Recording.2024-11-20.at.15.04.15.mov