Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Config System #2

Merged
merged 12 commits into from
Dec 22, 2023
Merged

[feat] Config System #2

merged 12 commits into from
Dec 22, 2023

Conversation

x3rt
Copy link
Contributor

@x3rt x3rt commented Dec 21, 2023 •
edited
Loading

Configuration System Update

Overview

This pull request introduces a streamlined configuration system to enhance program flexibility. The key additions include:

AssembliesToPublicize

  • Property: AssembliesToPublicize
  • Description: Array specifying assemblies to publicize. Default values: "Assembly-CSharp.dll," "Mirror.dll," "PluginAPI.dll."

ZipReferences

  • Property: ZipReferences
  • Description: Boolean flag to indicate whether to zip references. Default: true.

ReferencesZipName

  • Property: ReferencesZipName
  • Description: String representing the zip file name/path. Default: "References.zip."

SaveReferencesToFolder

  • Property: SaveReferencesToFolder
  • Description: Boolean flag to save references to a folder. Default: false.

ReferencesFolderName

  • Property: ReferencesFolderName
  • Description: String representing the reference directory. Default: "References."

Additionally the following (small) change has been made:

Release GitHub Action Task

  • Change: The task will now run only on tag pushes.

@x3rt x3rt marked this pull request as draft December 21, 2023 14:39
@x3rt x3rt marked this pull request as ready for review December 21, 2023 14:41
@x3rt x3rt marked this pull request as draft December 21, 2023 14:57
@x3rt
Copy link
Contributor Author

x3rt commented Dec 21, 2023

Going to try and update the build to net8 sorry

@x3rt x3rt marked this pull request as ready for review December 21, 2023 15:04
@x3rt x3rt changed the title Config [feat] Config System Dec 21, 2023
@x3rt x3rt mentioned this pull request Dec 21, 2023
Merged
Jesus-QC
Jesus-QC approved these changes Dec 22, 2023
View reviewed changes
Copy link
Owner

@Jesus-QC Jesus-QC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean code, good job! ❤️

@Jesus-QC Jesus-QC merged commit 09c4421 into Jesus-QC:master Dec 22, 2023
3 checks passed
@x3rt x3rt deleted the config branch December 22, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jesus-QC Jesus-QC Jesus-QC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@x3rt @Jesus-QC