Added option to use QueryString on some fields #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeroen-G
reviewed
Mar 5, 2024
| @@ -19,6 +19,7 @@ public function test_it_builds_the_right_query(): void | |||
| 'query' => 'test', | |||
| 'default_operator' => 'OR', | |||
| 'boost' => 1.0, | |||
| 'fields' => [], | |||
There was a problem hiding this comment.
Isn't it nicer (and maybe backwards compatible for other users) if the entire fields parameter is omitted if empty?
|
@Jeroen-G Agreeing with your comment from some weeks ago. Can search for some time to fix this. So this PR is not really needed; But what you think? Is this feature nice to have? Or maybe better to just close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some project we've needed to QueryString search on some specific fields.
This changes should be non-breaking, so I think there is no major release needed.
If you needed more information, feel free to reach out on Slack @Jeroen-G