Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling of the selected menu option into view for menuportals #5980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Scrolling of the selected menu option into view for menuportals #5980

wants to merge 2 commits into from

Conversation

m4g4
Copy link

@m4g4 m4g4 commented Dec 4, 2024

A fix for: #5663

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 337c235

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Dec 4, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

madelahsan
madelahsan suggested changes Dec 5, 2024
View reviewed changes
Copy link

@madelahsan madelahsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove isFocused from line number 886 as it is not being used and the test is being failed because of it.
image

@m4g4 m4g4 requested a review from madelahsan December 5, 2024 10:47
@konradekk
Copy link

konradekk commented Dec 9, 2024 •
edited
Loading

cross-ref: possibly fixes #5784, as well as #5775, #5663 and (probably) #3648 mentioned there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madelahsan madelahsan madelahsan approved these changes

@Thris3n Thris3n Thris3n approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m4g4 @konradekk @Thris3n @madelahsan