Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass form prop to input so it works even if the select is ouside the form tag #5782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zvin
Copy link

@zvin zvin commented Oct 19, 2023

Hello!

When using CreatableSelect outside of a form passing it a form prop, this prop is not passed to the created input resulting in the field not being submitted as part of the form.
This PR fixes it.

My problem was with CreatableSelect but it might fix other use cases as well.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 0e43b00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e43b00:

Sandbox Source
react-codesandboxer-example Configuration

@zvin zvin force-pushed the pass-form-prop-to-input branch from bcdab79 to 67a26b7 Compare October 19, 2023 11:09
@zvin zvin force-pushed the pass-form-prop-to-input branch from 44cbd06 to a177408 Compare February 2, 2024 07:42
@zvin zvin force-pushed the pass-form-prop-to-input branch from a177408 to 0e43b00 Compare February 2, 2024 09:47
@zvin
Copy link
Author

zvin commented Feb 5, 2024

Using a regular select will submit the myField value.

<div>
  <form action="/someAction" id="myForm">
    <input type="submit" />
  </form>
  <select form="myForm" name="myField">
    <option value="x">X</option>
    <option value="y">Y</option>
  </select>
<div>

Using React-Select, it won't.

<div>
  <form action="/someAction" id="myForm">
    <input type="submit" />
  </form>
  <Select form="myForm" name="myField" options={[{ value:"x", label: "X" }, { value:"y", label: "Y" }]} />
<div>

This PR fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant