Fill purpose for examples other than Template, Game Physics, and HGHC
#3398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrzhuang
requested review from
JacquesCarette,
smiths,
samm82,
bmaclach and
cd155
as code owners
samm82
requested changes
May 9, 2023
Co-authored-by: Sam Crawford <[email protected]>
samm82
approved these changes
May 10, 2023
JacquesCarette
approved these changes
May 10, 2023
There was a problem hiding this comment.
FYI: it actually would have been better to have done one PR per example. Many small PRs are better than larger ones.
Main reason: one issue in one part can hold up a big PR from being merged. If it's many, then most will get merged right away, and only the problematic part will be held up.
|
(Should I delete this branch, or will you re-use it for the other examples, or are you done for now?) |
|
Noted, thanks for letting me know! I will delete this branch now and create separate branches for the outstanding examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3391.
purposeis lifted from the existing introductions of the Problem Description sections. Template and HGHC are excluded since they do not have such an introduction. Game Physics is excluded since its introduction is too long.