Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Extract Entry Editor #12210

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

[wip] Extract Entry Editor #12210

wants to merge 9 commits into from

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Nov 18, 2024

Instead of having an instance of the EntryEditor for every LibraryTab - one is enough. One EntryEditor to rule them all, one EntryEditor to find them, one Entryeditor to bring them all and in the bottom of the interface bind them.

Wip.

Introduced

  • Interface PreviewControls

Todo:

  • Move Open/Close of EntryEditor to JabRefFrame
  • Adapt EntryEditor to follow observables and to tolerate no entry
  • Adapt StateManager from DatabaseContext to LibraryTab?
  • ...

Goal:

  • Level of abstraction? (LibraryTab in StateManager instead of BibDatabaseContext)
  • Easy rewrite of entry editor in the future
  • Unwind dependencies

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus force-pushed the extract-entry-editor branch from fe21d9b to f247c7c Compare November 30, 2024 10:49
@subhramit subhramit added type: code-quality Issues related to code or architecture decisions type: enhancement labels Dec 2, 2024
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/12210/merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code-quality Issues related to code or architecture decisions type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants