-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pdf to bib #12138
add pdf to bib #12138
Conversation
1. remove double space in unit test 2. fix a logic bug about space. 3. skip the normal space in the title character 4. rename pdf use last name not first name
fix EqualsAvoidsNull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use OpenRewrite to ensure "modern" Java coding practices.
The issues found can be automatically fixed.
Please execute the gradle task rewriteRun
, check the results, commit, and push.
You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
fix unit test issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment
url = {https://www.computer.org/csdl/magazine/ds/2002/02/o2001/13rRUEgs2Q8} | ||
year = {2002} | ||
file = {Baldoni2002.pdf} | ||
doi = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line. - We do not distinguish between "unknown DOI" and no DOI available.
@@ -254,6 +254,9 @@ private boolean isUnwantedText(TextPosition previousTextPosition, TextPosition t | |||
if (textPosition == null || previousTextPosition == null) { | |||
return false; | |||
} | |||
if (" ".equals(textPosition.getUnicode())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, there could be multiple spaces etc.
if (" ".equals(textPosition.getUnicode())) { | |
if (StringUtil.isBlank(textPosition.getUnicode())) { |
remove doi
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)