Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine PULL_REQUEST_TEMPLATE.md #12094

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Refine PULL_REQUEST_TEMPLATE.md #12094

merged 1 commit into from
Oct 26, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 26, 2024

Some students do not add a CHANGELOG.md entry, even if they should (e.g., #12081)

This PR tries to refine the text for the check.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Oct 26, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus merged commit 95f7db2 into main Oct 26, 2024
26 of 27 checks passed
@calixtus calixtus deleted the koppor-patch-1 branch October 26, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants