Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11219 adapt UI font size #12042

Merged
merged 29 commits into from
Dec 2, 2024
Merged

11219 adapt UI font size #12042

merged 29 commits into from
Dec 2, 2024

Conversation

harry924
Copy link
Contributor

@harry924 harry924 commented Oct 20, 2024 •
edited by calixtus
Loading

closes #11219
Merged all the CSS files to Base.css

converted all px units to em

Fixed toggle button and sperator padding issue

Conducted UI testing by comparing interfaces before and after changes.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Separator-issue

Fixed-Separator

misaligned-filter-icon

Fixed-filter-icon

@Siedlerchr
Copy link
Member

then remove the unused css files as well

Siedlerchr
Siedlerchr requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the unused css files and check if they are referenced somehwere

@Siedlerchr Siedlerchr added the status: changes required Pull requests that are not yet complete label Oct 20, 2024
@harry924
Copy link
Contributor Author

Hi, I have deleted original individual CSS files and the BaseBackUp.css and consolidated styles into Base.css.
and also updated all the relevant Java classes to reference Base.css instead of the deleted files.

koppor
koppor reviewed Oct 24, 2024
View reviewed changes
docs/_config.yml Outdated Show resolved Hide resolved
koppor
koppor requested changes Oct 26, 2024
View reviewed changes
docs/_config.yml Outdated Show resolved Hide resolved
docs/mkdocs-custom.css Outdated Show resolved Hide resolved
@calixtus calixtus added ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes required Pull requests that are not yet complete labels Nov 25, 2024
@calixtus calixtus requested a review from Siedlerchr November 25, 2024 23:54
@HoussemNasri
Copy link
Member

HoussemNasri commented Nov 30, 2024 •
edited
Loading

The changes look good to me. However, the pull request does more than just adapt font size. For instance, the merging of all CSS styles into Base.css could be a source of regressions, so I recommend for adding multiple entries to the changelog or merge the individual commits without squash.

@Siedlerchr
Copy link
Member

Overall looks good, however, JabRef opens always maximized, even if I resize it and move it to the screen center but this might be another issue because I reset my prefs as well

@Siedlerchr
Copy link
Member

Changelog should contain a note about the effect of custom themes!

@calixtus
Copy link
Member

@InAnYan I took the liberty to simplify the privacy component and to make it a bit more coherent to the mrdlib privacy dialog. Can you also take a look?

InAnYan
InAnYan previously requested changes Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@InAnYan InAnYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Good! There are some small issues

Siedlerchr
Siedlerchr previously approved these changes Nov 30, 2024
View reviewed changes
@calixtus calixtus enabled auto-merge December 2, 2024 20:56
@calixtus calixtus disabled auto-merge December 2, 2024 20:59
@calixtus
Copy link
Member

calixtus commented Dec 2, 2024

grafik

@calixtus calixtus enabled auto-merge December 2, 2024 21:12
@calixtus calixtus added this pull request to the merge queue Dec 2, 2024
@calixtus
Copy link
Member

calixtus commented Dec 2, 2024

GPT4all privacy link was the same as before. Change it in another pr as this is focused on css and ui

Merged via the queue into JabRef:main with commit 4dea5fa Dec 2, 2024
23 checks passed
Siedlerchr added a commit that referenced this pull request Dec 6, 2024
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-rpm-uninstall
137c0a0 
* upstream/main:
  New Crowdin updates (#12264)
  New Crowdin updates (#12263)
  11219 adapt UI font size (#12042)
  Added support for (biblatex) `langid` to be an optional field in entry editor (#12071)
  improve unlinked files dialog (#12195)
  Reword 0034-use-citation-key-for-grouping-chat-messages.md (#12183)
  Bump dev.langchain4j:langchain4j-open-ai from 0.36.0 to 0.36.2 (#12259)
  Bump io.zonky.test.postgres:embedded-postgres-binaries-bom (#12258)
  Bump tech.units:indriya from 2.2 to 2.2.1 (#12257)
  Bump org.jetbrains.kotlin:kotlin-stdlib-jdk8 from 2.0.21 to 2.1.0 (#12256)
  Bump io.github.classgraph:classgraph from 4.8.177 to 4.8.179 (#12255)
  Bump src/main/resources/csl-styles from `b90b81a` to `6b7b611` (#12254)
  Add hints on research (and BibTeX) to README.md (#12253)
  Disable non-working Openrewrite recipe
  always set maximized  to false on exit for mac (#12248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus left review comments

@koppor koppor koppor approved these changes

@InAnYan InAnYan InAnYan left review comments

@Siedlerchr Siedlerchr Siedlerchr left review comments

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JabRef's UI should adapt to the font size
6 participants
@harry924 @Siedlerchr @HoussemNasri @calixtus @koppor @InAnYan