Disable menu items for unsaved library

Fixes #11920

CHANGELOG.md

@@ -76,6 +76,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We changed the name of the library-based file directory from 'General File Directory' to 'Library-specific File Directory' per issue. [#571](https://github.com/koppor/jabref/issues/571)
 - We changed the defualt [unwanted charachters](https://docs.jabref.org/setup/citationkeypatterns#removing-unwanted-characters) in the citation key generator and allow a dash (`-`) and colon (`:`) being part of a citation key. [#12144](https://github.com/JabRef/jabref/pull/12144)
 - The CitationKey column is now a default shown column for the entry table. [#10510](https://github.com/JabRef/jabref/issues/10510)
+- We disabled the actions "Open Terminal here" and "Reveal in file explorer" for unsaved libraries [#11920](https://github.com/JabRef/jabref/issues/11920)
 
 ### Fixed
 

src/main/java/org/jabref/gui/actions/ActionHelper.java

@@ -29,6 +29,11 @@ public static BooleanExpression needsDatabase(StateManager stateManager) {
         return stateManager.activeDatabaseProperty().isPresent();
     }
 
+    public static BooleanExpression needsSavedLocalDatabase(StateManager stateManager) {
+        EasyBinding<Boolean> binding = EasyBind.map(stateManager.activeDatabaseProperty(), context -> context.filter(c -> c.getLocation() == DatabaseLocation.LOCAL && c.getDatabasePath().isPresent()).isPresent());
+        return BooleanExpression.booleanExpression(binding);
+    }
+
     public static BooleanExpression needsSharedDatabase(StateManager stateManager) {
         EasyBinding<Boolean> binding = EasyBind.map(stateManager.activeDatabaseProperty(), context -> context.filter(c -> c.getLocation() == DatabaseLocation.SHARED).isPresent());
         return BooleanExpression.booleanExpression(binding);
@@ -49,7 +54,7 @@ public static BooleanExpression needsEntriesSelected(StateManager stateManager)
 
     public static BooleanExpression needsEntriesSelected(int numberOfEntries, StateManager stateManager) {
         return Bindings.createBooleanBinding(() -> stateManager.getSelectedEntries().size() == numberOfEntries,
-                                             stateManager.getSelectedEntries());
+                stateManager.getSelectedEntries());
     }
 
     public static BooleanExpression isFieldSetForSelectedEntry(Field field, StateManager stateManager) {

src/main/java/org/jabref/gui/frame/JabRefFrame.java

@@ -64,6 +64,9 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import static org.jabref.gui.actions.ActionHelper.needsDatabase;
+import static org.jabref.gui.actions.ActionHelper.needsSavedLocalDatabase;
+
 /**
  * Represents the inner frame of the JabRef window
  */
@@ -79,7 +82,6 @@ public class JabRefFrame extends BorderPane implements LibraryTabContainer, UiMe
     private final GlobalSearchBar globalSearchBar;
 
     private final FileHistoryMenu fileHistory;
-    private final FrameDndHandler frameDndHandler;
 
     @SuppressWarnings({"FieldCanBeLocal"}) private EasyObservableList<BibDatabaseContext> openDatabaseList;
 
@@ -136,7 +138,7 @@ public JabRefFrame(Stage mainStage,
                 taskExecutor);
         Injector.setModelOrService(UiMessageHandler.class, viewModel);
 
-        this.frameDndHandler = new FrameDndHandler(
+        FrameDndHandler frameDndHandler = new FrameDndHandler(
                 tabbedPane,
                 mainStage::getScene,
                 this::getOpenDatabaseAction,
@@ -425,7 +427,7 @@ public void showLibraryTab(@NonNull LibraryTab libraryTab) {
     /**
      * Opens a new tab with existing data.
      * Asynchronous loading is done at {@link LibraryTab#createLibraryTab}.
-     * Similar method: {@link OpenDatabaseAction#openTheFile(Path)}
+     * Similar method: {@link OpenDatabaseAction#openTheFile(Path)} (Path)}
      */
     public void addTab(@NonNull BibDatabaseContext databaseContext, boolean raisePanel) {
         Objects.requireNonNull(databaseContext);
@@ -637,6 +639,7 @@ private class OpenDatabaseFolder extends SimpleCommand {
 
         public OpenDatabaseFolder(Supplier<BibDatabaseContext> databaseContext) {
             this.databaseContext = databaseContext;
+            this.executable.bind(needsSavedLocalDatabase(stateManager));
         }
 
         @Override

src/main/java/org/jabref/gui/frame/OpenConsoleAction.java

@@ -35,7 +35,7 @@ public OpenConsoleAction(Supplier<BibDatabaseContext> databaseContext, StateMana
         this.preferences = preferences;
         this.dialogService = dialogService;
 
-        this.executable.bind(ActionHelper.needsDatabase(stateManager));
+        this.executable.bind(ActionHelper.needsSavedLocalDatabase(stateManager));
     }
 
     /**