Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "View" link #167

Merged
merged 3 commits into from
Aug 28, 2022
Merged

Add "View" link #167

merged 3 commits into from
Aug 28, 2022

Conversation

AlecRust
Copy link
Contributor

@AlecRust AlecRust commented Aug 5, 2022

Current problem

It's a WordPress convention to have a "View" link in the table when hovering over each row (see main "Posts" table etc.).

I expected this to be there on your mail log table, but it wasn't. This was far off to the right of my screen behind a "More info" button.

As mentioned in #149 I would go for the more conventional "View" link here instead of the "More info" button.

Proposed solution

  • Add "View" link to links that appear on row hover
  • Remove "More info" column and button

Could even go a step further here and make the email address bold and linked to the same place, to match WordPress conventions even more, and ensure a "view" link was always visible regardless of hover:

image

Screenshots

Before:
image

After:
image


resolves second item of #149

@JWardee
Copy link
Owner

JWardee commented Aug 10, 2022

Hi @AlecRust, thanks for taking the time to submit the PR.

  • I'm happy for the additional "View" link to be added - which, when clicked would open the "more details" modal.
  • I'm not keen on removing the "More info" button because that's been there since the first release and I want to avoid having support requests from people wondering where/why it's been changed.
  • I'm also happy for the email address to be bolded and linked to the "more details" modal.
  • I think it's best to keep the links visible on hover only - as it currently is, I appreciate other areas of the WP admin may have this visible at all times but I would like to keep this more minimal.

@AlecRust
Copy link
Contributor Author

I'm happy for the additional "View" link to be added - which, when clicked would open the "more details" modal.

Sounds good. I've scaled back this PR to just add this.

I'm also happy for the email address to be bolded and linked to the "more details" modal.

Cool, I may look at this in following PR.

Sounds good regarding your other points 👍

@AlecRust AlecRust changed the title Replace "More info" button with "View" link Add "View" link Aug 11, 2022
Copy link
Owner

@JWardee JWardee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JWardee JWardee merged commit 5cd1ac3 into JWardee:master Aug 28, 2022
@AlecRust AlecRust deleted the improve-view branch August 28, 2022 20:51
@AlecRust AlecRust mentioned this pull request Aug 28, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants