Skip to content

Commit

Permalink
Update to WiX 3.14.0 for security vulnerability fix
Browse files Browse the repository at this point in the history
  • Loading branch information
JVimes committed Feb 9, 2024
1 parent ed57f1e commit b27e9c9
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
2 changes: 1 addition & 1 deletion BuildInstaller/BuildInstaller.nuspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<readme>ReadMe.md</readme>

<dependencies>
<dependency id="WiX" version="3.11.2" />
<dependency id="WiX" version="3.14.0" />
</dependencies>
</metadata>
<files>
Expand Down
12 changes: 9 additions & 3 deletions ReadMe.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# BuildInstaller
## BuildInstaller

BuildInstaller is a NuGet package that causes a Visual Studio project to produce an installer during Release builds (configurable). It has been tested with .NET projects and might need changes to support other types. The installer is a .msi file (Windows Installer package).

The project's output files will be installed under Program Files and an application shortcut placed at the root of Start menu. Running the installer again gives access to the Remove and Repair buttons. The application can also be uninstalled via Apps & Features.

# Use
# Using It

Install the BuildInstaller package in your application's project. On Release builds the installer will appear in:

Expand Down Expand Up @@ -100,9 +100,15 @@ These items are:

The installer is built using [The WiX Toolset][WiXUrl]. The installer can be customized by editing Product.wxs and SimpleUI.wxs which are created in [Project]\Installer\ on first installer build, or by adding other WiX source code files to that folder.

---

# Developing BuildInstaller

There are sometimes errors the first time the solution or TestApp.OldProjFormat are built. The errors seem to go away if build is run a second time (something to do with NuGet restore?).
In Visual Studio, the first solution build will fail on the TestApp.OldProjFormat project:

> The command ""\heat.exe" dir "bin\Debug\\" ... exited with code 9009.
After this error, right click its project in Solution Explorer and select **Rebuild**. It should build and the solution should build after that.

The **BuildInstaller project** builds the NuGet package and deletes local caches of it.
- Its PackageFiles folder holds MSBuild files that run in projects that use BuildInstaller.
Expand Down
4 changes: 2 additions & 2 deletions TestApp.OldProjFormat/TestApp.OldProjFormat.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="..\packages\WiX.3.11.2\build\wix.props" Condition="Exists('..\packages\WiX.3.11.2\build\wix.props')" />
<Import Project="..\packages\wix.3.14.0\build\wix.props" Condition="Exists('..\packages\wix.3.14.0\build\wix.props')" />
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<InstallerBuildConfigurations>Debug;Release</InstallerBuildConfigurations>
Expand Down Expand Up @@ -110,7 +110,7 @@
<PropertyGroup>
<ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
</PropertyGroup>
<Error Condition="!Exists('..\packages\WiX.3.11.2\build\wix.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\WiX.3.11.2\build\wix.props'))" />
<Error Condition="!Exists('..\packages\wix.3.14.0\build\wix.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\wix.3.14.0\build\wix.props'))" />
<Error Condition="!Exists('..\packages\BuildInstaller.1.0.1\build\BuildInstaller.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\BuildInstaller.1.0.1\build\BuildInstaller.targets'))" />
</Target>
<Import Project="..\packages\BuildInstaller.1.0.1\build\BuildInstaller.targets" Condition="Exists('..\packages\BuildInstaller.1.0.1\build\BuildInstaller.targets')" />
Expand Down
2 changes: 1 addition & 1 deletion TestApp.OldProjFormat/packages.config
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="BuildInstaller" version="1.0.1" targetFramework="net48" developmentDependency="true" />
<package id="WiX" version="3.11.2" targetFramework="net48" />
<package id="WiX" version="3.14.0" targetFramework="net48" />
</packages>

0 comments on commit b27e9c9

Please sign in to comment.