This repository has been archived by the owner on May 5, 2021. It is now read-only.
Escaping/unescaping special chars from headers #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for #77. I still have some doubts about it.
The issue is about escaping backslash, but the specification only mentions escaping "any carriage return, line feed or colon":
The backslash is only mentioned on the frame headers decoding:
I do agree that escaping it makes sense but I have followed the "strict" interpretation of the spec. What are your thoughts about it?
Another point is that each spec version has some difference between what should be escaped. So, the implementation assumes that we must follow the rules from the connected version. Is this really necessary? It would be simpler to just follow the 1.2 version.
Last but not least, the webstomp-client was trimming the header values, I have removed that based on:
Sorry about the text wall, but the issue turned a little bit more tricky than expected 😄