Redo PR3 from phamernik/i18nchecker #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow use of ResouceBundle.getBundle().getString to be counted as using a key.
…ame line as that method (should check that getBundle is on same line as the identifier ResourceBundle). Add check for getString() method, and treat String literals on the same line as that method as Strings needing to be translated.
Why do IDEs seems to always arbitrarily change projects?
If a logger and its methods are specified, String literals used as parameters to the specified methods of the logger will be ignored (eventually, this commit just specifies the properties).
….properties files.
This was referenced Nov 28, 2022
|
This PR should be closed since it's replaced by #5 but I don't have permissions to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge reproduces PR3 from phamernik/i18nchecker. That's what underlies the i18nchecker version currently used by JMRI.
Note that this does not exactly reproduce the .jar file. It's not yet clear why. Perhaps compiler version differences? They both show (via
javap)due to the constraints in the build.xml file and children, but the current compile is still being done with Java 1.8.