Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better multi monitor support #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better multi monitor support #139

wants to merge 1 commit into from

Conversation

mgurga
Copy link

@mgurga mgurga commented Jun 21, 2021

Fixes a problem where fullscreen, monocle, and other functions would only use the first monitor. The commit creates a method that finds which monitor a client is on and passes it to the fullscreen, monocle, and other functions. This PR also partly addresses #18.

@JLErvin
Copy link
Owner

JLErvin commented Jun 22, 2021

Hmmmm, this might require a bit of investigation. The purpose of the ws_m_list (which, I think is poorly named and should be more verbose for a variable which has global scope) is to map workspaces onto monitors. Since each client maintains it's active workspace, it should be the case that we can correctly identify which monitor it is on using the list as a lookup. It's likely the case that this is not getting updated properly in some instances - leading to the bug.

I will look into this a bit. I'm quite busy nowadays, however, so if I can't find anything soon I'll just merge this change to be pragmatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants