Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enum support #482

Merged
merged 5 commits into from
Aug 12, 2024
Merged

feat: Enum support #482

merged 5 commits into from
Aug 12, 2024

Conversation

IvanJosipovic
Copy link
Owner

@IvanJosipovic IvanJosipovic commented Aug 1, 2024

Creates Enums for string types

Waiting for YamlDotNet 16 support for EnumMember

kubernetes-client/csharp#1573

@IvanJosipovic IvanJosipovic marked this pull request as ready for review August 12, 2024 17:25
@IvanJosipovic IvanJosipovic enabled auto-merge (squash) August 12, 2024 17:25
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 89.83051% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.36%. Comparing base (877b359) to head (b5e865f).

Files Patch % Lines
src/KubernetesCRDModelGen/Generator.cs 89.83% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            alpha     #482      +/-   ##
==========================================
- Coverage   84.03%   81.36%   -2.67%     
==========================================
  Files           2        1       -1     
  Lines         382      322      -60     
  Branches       36       42       +6     
==========================================
- Hits          321      262      -59     
+ Misses         51       48       -3     
- Partials       10       12       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IvanJosipovic IvanJosipovic merged commit 740a5f9 into alpha Aug 12, 2024
2 of 3 checks passed
@IvanJosipovic IvanJosipovic deleted the enum branch August 12, 2024 17:28
Copy link
Contributor

🎉 This PR is included in version 1.0.0-alpha.303 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant