-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fedora docs #2240
Update Fedora docs #2240
Conversation
Add syntax highlighting and copy buttons
I think the preview action is trying to push to Islandora/documentation, but as me? https://github.com/Islandora/documentation/actions/runs/5245070365/jobs/9471983399?pr=2240#step:4:198 Then it gives some other error https://github.com/Islandora/documentation/actions/runs/5245070365/jobs/9471983399?pr=2240#step:4:268 |
@whikloj : Just, rationale for the "preview" thing having failed: https://github.com/rossjrw/pr-preview-action
|
Ohhhh so I should have opened this from the documentation repo. I'll try to remember that in the future. |
I was just trying a pull request from my fork to see if that was the reason, but now I see that it was confirmed as the reason. At least it gave me an excuse to create a PR I had been meaning to create. |
Looks great. I got to the bottom of the file and things worked. The only error I got was that comments in the fcrepo.properties file aren't valid, so I made a PR with a small warning to take them out. whikloj#1 I will admit I haven't finished the manual install instructions, but this page seems good to go (with the small addition above). |
Hey @rosiel, sorry about that. I moved the comments to their own lines. I can still merge your addition, but this allows the copy block to work. |
Purpose / why
Update the Fedora parts of this based on our experience setting up Fedora/Syn
What changes were made?
Verification
Compare to the final installation inside Isle or playbook, or give it a try.
Interested Parties
Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:
Person Merging
The person merging should ensure the following: