Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update(home): Show home feed and refactoring listener home adapter #3

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

IrfanNawawi
Copy link
Owner

No description provided.

val scrollY: Int = binding.rvHome.computeVerticalScrollOffset()
val color = ColorUtils.changeAlpha(
ContextCompat.getColor(requireActivity(), ProjectColor.black_transparent),
(min(255, scrollY).toFloat() / 255.0f).toDouble()

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
val scrollY: Int = binding.rvHome.computeVerticalScrollOffset()
val color = ColorUtils.changeAlpha(
ContextCompat.getColor(requireActivity(), ProjectColor.black_transparent),
(min(255, scrollY).toFloat() / 255.0f).toDouble()

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
@@ -0,0 +1,53 @@
package id.heycoding.home.presentation.ui.home

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/LayarTancepXXI/LayarTancepXXI/feature/home/src/main/java/id/heycoding/home/presentation/ui/home/HomeViewModel.kt is not ending with a new line.
@IrfanNawawi IrfanNawawi merged commit 44de32b into master Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant