Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new nothunks #5616

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Update to new nothunks #5616

merged 3 commits into from
Nov 9, 2023

Conversation

michaelpj
Copy link
Contributor

ouroboros-network-framework now has a lower bound on this, so we need to be compatible with it. It adds a conflicting instance, so we need to remove that and also update our lower bound too.

@michaelpj michaelpj added the No Changelog Required Add this to skip the Changelog Check label Nov 8, 2023
kwxm
kwxm approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@kwxm kwxm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, as far as I can tell. If it passes CI it should be good to merge.

@michaelpj michaelpj merged commit ac8e838 into master Nov 9, 2023
5 of 59 checks passed
@michaelpj michaelpj deleted the mpj/nothunks-1.4 branch November 9, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwxm kwxm kwxm approved these changes

Assignees
No one assigned
Labels
No Changelog Required Add this to skip the Changelog Check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelpj @kwxm