-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace transaction replies in txSubmissionOutbound after transactions are sent #1863
base: main
Are you sure you want to change the base?
Conversation
ee54f98
to
a5cb1f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-- Trace the transactions to be sent in the response. | ||
traceWith tracer (TraceTxSubmissionOutboundSendMsgReplyTxs txs) | ||
-- Trace the transactions to be sent in the response. | ||
traceTxsSent = traceWith tracer (TraceTxSubmissionOutboundSendMsgReplyTxs txs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a comment (here or near L195) saying that tracing itself will be executed after sending the reply.
@mrBliss: Do you feel the same way about the approach in the first commit?
|
a5cb1f8
to
8fad020
Compare
8fad020
to
fd05404
Compare
32719f7
to
05436f9
Compare
05436f9
to
f3e301e
Compare
I noticed that in #1688 I was mistakenly tracing
TraceTxSubmissionOutboundSendMsgReplyTxs
events before the transactions had been successfully sent.