Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-testnet-data: use experimental API and make arguments era specific #968

Draft
wants to merge 4 commits into
base: smelc/use-inject-instead-of-XtoY-era-functions
Choose a base branch
from

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 14, 2024

Changelog

- description: |
    More fine grained controls of eras for create-testnet-data. Forbid creating DReps and CC in babbage.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #962

How to trust this PR

Look at the changes in golden files

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc added the next-update Needs a dependency to be updated to be merged label Nov 14, 2024
@smelc smelc force-pushed the smelc/parameterize-create-testnet-data-on-exp-era branch 2 times, most recently from a6188ed to a53325e Compare November 15, 2024 08:31
@smelc smelc force-pushed the smelc/parameterize-create-testnet-data-on-exp-era branch from a53325e to cf64c8b Compare November 15, 2024 09:45
@smelc smelc changed the base branch from master to smelc/use-inject-instead-of-XtoY-era-functions November 15, 2024 09:45
@smelc smelc force-pushed the smelc/use-inject-instead-of-XtoY-era-functions branch from b9c394f to 9c3bac2 Compare November 15, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More fine grained era control in create-testnet-data
1 participant