Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsers: avoid double usage of flip on a single line #964

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 8, 2024

Changelog

- description: |
    Simplify a parser, by making it more readable
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Small improvement found when working on #763

How to trust this PR

Typechecking suffices to make sure this is sound

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc force-pushed the smelc/simplify-protocol-magic-parser branch from 9286b92 to a50286c Compare November 8, 2024 16:01
@smelc smelc enabled auto-merge November 8, 2024 16:01
@smelc smelc added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit 003373f Nov 12, 2024
25 checks passed
@smelc smelc deleted the smelc/simplify-protocol-magic-parser branch November 12, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants