-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on optparse-applicative instead of optparse-applicative-fork #899
base: master
Are you sure you want to change the base?
Conversation
@@ -45,8 +45,8 @@ pref = | |||
Opt.prefs $ | |||
mconcat | |||
[ showHelpOnEmpty | |||
, helpEmbedBriefDesc PP.align | |||
, helpRenderHelp customRenderHelp | |||
-- , helpEmbedBriefDesc PP.align |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PP.align
value is the magical configuration bit that makes the golden files still look good. The changes in https://github.com/smelc/optparse-applicative/commits/smelc/wip-cardano-cli-usecase/ are hardcoding this configuration change for now, but my plan is to make a PR to optparse-applicative
to make this configurable.
bed54fc
to
3be2b7c
Compare
c7ed606
to
62b33cc
Compare
c6f2764
to
f974a10
Compare
f974a10
to
7d32504
Compare
7d32504
to
13cfd22
Compare
Note
Requires a release of optparse-applicative > 0.18.1 to be merged
Changelog
Context
We want to get rid on our dependency to optparse-applicative-fork here: cardano-cli/cardano-cli.cabal#L245.
This PR does this, as well as showing what it happens if we take a vanilla version of
optparse-applicative
. This is what the commitChanges to golden files WITHOUT change to optparse-applicative
shows.Then the last commit, named
Changes to golden files WITH change to optparse-applicative
shows what we can achieve if we tweakoptparse-applicative
slightly. In this case the changes to golden files is minimal (pipes move to the left, and then are more single line disjunctions, but they are fine IMHO).How to trust this PR
Look at the golden files. See that the end state is quite nice.
Checklist