Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query a node for a snapshot of big ledger peers #727

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Query a node for a snapshot of big ledger peers #727

wants to merge 2 commits into from

Conversation

crocodile-dentist
Copy link
Contributor

@crocodile-dentist crocodile-dentist commented Apr 18, 2024 •
edited
Loading

Changelog

- description: |
   added QueryLedgerPeerSnapshotCmd for a snapshot of big ledger peers used when syncing in Genesis
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

A new query subcommand ledger-peer-snapshot was introduced to serialize a snapshot of big ledger peers. These relays will be relied on by network layer when a node is syncing up in Genesis consensus mode, since a node may not have any or up to date information from its own ledger which are the big ledger peer relays.

Closes #571

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch from d331184 to 141ce47 Compare April 18, 2024 11:49
carbolymer
carbolymer approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! There are build failures though.

cardano-cli/CHANGELOG.md Outdated Show resolved Hide resolved
cardano-cli/src/Cardano/CLI/Legacy/Options.hs Outdated Show resolved Hide resolved
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch from 141ce47 to ab2200d Compare April 22, 2024 09:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jun 7, 2024
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch from ab2200d to 846fbcb Compare June 7, 2024 10:46
@github-actions github-actions bot removed the Stale label Jun 8, 2024
@smelc
Copy link
Contributor

smelc commented Jun 10, 2024

Seems this is blocked on updated in https://github.com/IntersectMBO/ouroboros-network, so putting as draft until this is really mergeable. @crocodile-dentist> please undraft when this is close to being merged.

@smelc smelc marked this pull request as draft June 10, 2024 12:50
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch 3 times, most recently from 1a78bfc to 913c44d Compare June 18, 2024 09:24
@palas
Copy link
Contributor

palas commented Jul 15, 2024

Backup: https://github.com/IntersectMBO/cardano-cli/tree/backup/mwojtowicz/ledger-query-peer-snapshot

@palas palas force-pushed the mwojtowicz/ledger-query-peer-snapshot branch 2 times, most recently from 36449ee to cb5eebc Compare July 15, 2024 22:54
@palas
Copy link
Contributor

palas commented Jul 15, 2024

FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch that you can find in my previous comment in this PR.

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch from cb5eebc to 72a6466 Compare August 5, 2024 10:57
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch 2 times, most recently from 7e4c792 to 00a96fb Compare August 8, 2024 13:55
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Sep 23, 2024
@github-actions github-actions bot removed the Stale label Oct 15, 2024
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch 3 times, most recently from 9ac33cb to e440808 Compare November 13, 2024 13:26
@crocodile-dentist crocodile-dentist marked this pull request as ready for review November 13, 2024 13:30
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch 3 times, most recently from dd0b6df to a3f03fe Compare November 13, 2024 14:43
@carbolymer carbolymer self-requested a review November 14, 2024 12:44
carbolymer
carbolymer reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are build failures, and needs a rebase.

Can you also run: RECREATE_GOLDEN_FILES=1 cabal test cardano-cli-golden to recreate golden files?

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch 4 times, most recently from fcd1531 to 763030b Compare November 15, 2024 09:34
@crocodile-dentist
Add ledger-peer-snapshot to query command:
c5390a9 
This change introduces query subcommand ledger-peer-snapshot to
serialize a snapshot of big ledger peers from the tip of the current
chain.
@crocodile-dentist
srp
fe0ed80
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/ledger-query-peer-snapshot branch from 763030b to fe0ed80 Compare November 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@smelc smelc smelc approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cardano-cli command which outputs ledger peers
4 participants
@crocodile-dentist @smelc @palas @carbolymer