-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-villager-cap-flag #4357
base: main
Are you sure you want to change the base?
feat-villager-cap-flag #4357
Conversation
return EntityUtil | ||
.checkEntity(plot, EntityCapFlag.ENTITY_CAP_UNLIMITED, MobCapFlag.MOB_CAP_UNLIMITED, | ||
AnimalCapFlag.ANIMAL_CAP_UNLIMITED | ||
); | ||
} | ||
|
||
if(EntityCategories.VILLAGER.contains(entityType)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code style
return EntityUtil | ||
.checkEntity(plot, EntityCapFlag.ENTITY_CAP_UNLIMITED, MobCapFlag.MOB_CAP_UNLIMITED, | ||
VillagerCapFlag.VILLAGER_CAP_UNLIMITED | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure we should remove villagers from the animal cap?
} else if (EntityCategories.ANIMAL.contains(entityType) || EntityCategories.VILLAGER.contains(entityType) || EntityCategories.TAMEABLE | ||
} else if (EntityCategories.VILLAGER.contains(entityType)) { | ||
count[CAP_MOB]++; | ||
count[CAP_VILLAGER]++; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here for animal cap
import com.plotsquared.core.plot.flag.types.NonNegativeIntegerFlag; | ||
import org.checkerframework.checker.nullness.qual.NonNull; | ||
|
||
public class VillagerCapFlag extends NonNegativeIntegerFlag<VillagerCapFlag> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@since TODO
tag
Fixes #4269
Description
With this feature we can limit villagers, useful for some servers that only want to control villagers, which is the case in most cbs servers.