feat: implement command to fix block connections #2746

dordsor21 · 2024-05-26T16:30:07Z

closes Connections Command #313

dordsor21 · 2024-05-26T16:30:59Z

...core/src/main/java/com/fastasyncworldedit/core/extent/processor/PlacementStateProcessor.java

PierreSchwang · 2024-05-27T17:56:15Z

The copyright header is missing in some files, no (e.g. FaweMutableBlockPlaceContext.java)? Though I'm wondering why the CI is not failing on that

dordsor21 · 2024-05-27T18:39:29Z

The copyright header is missing in some files, no (e.g. FaweMutableBlockPlaceContext.java)? Though I'm wondering why the CI is not failing on that

That should be because licences are only required in worldedit packages/classes

github-actions · 2024-06-10T18:13:21Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2024-06-20T18:51:29Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2024-06-27T13:15:55Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2024-06-27T13:15:55Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

AGuyNamedJens · 2024-07-10T16:00:04Z

I couldn't wait for release (over 100k blocks.. not connected.. help) and can confirm, it works, however console does show an error [17:58:33 WARN]: [com.fastasyncworldedit.core.queue.implementation.ParallelQueueExtent] Cannot invoke "net.minecraft.core.Holder.a()" because "this.E" is null [17:58:33 ERROR]: [com.fastasyncworldedit.core.queue.implementation.ParallelQueueExtent] Catching java.lang.NullPointerException: Cannot invoke "net.minecraft.core.Holder.a()" because "this.E" is null

dordsor21 · 2024-07-10T16:00:59Z

What's the full error?

AGuyNamedJens · 2024-07-10T16:03:35Z

[18:02:23 ERROR]: [com.fastasyncworldedit.core.queue.implementation.ParallelQueueExtent] Catching
java.lang.NullPointerException: Cannot invoke "net.minecraft.core.Holder.a()" because "this.E" is null
        at net.minecraft.world.level.Level.dimensionType(Level.java:1796) ~[?:?]
        at net.minecraft.world.level.LevelReader.getMinBuildHeight(LevelReader.java:86) ~[?:?]
        at net.minecraft.world.level.LevelHeightAccessor.getMaxBuildHeight(LevelHeightAccessor.java:12) ~[purpur-1.20.4.jar:git-Purpur-2176]
        at net.minecraft.world.level.block.DoublePlantBlock.getStateForPlacement(DoublePlantBlock.java:53) ~[?:?]
        at com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R3.PaperweightPlacementStateProcessor.getStateAtFor(PaperweightPlacementStateProcessor.java:63) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.processor.PlacementStateProcessor.getBlockOrdinal(PlacementStateProcessor.java:436) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.processor.PlacementStateProcessor.applyBlock(PlacementStateProcessor.java:452) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.filter.LinkedFilter.applyBlock(LinkedFilter.java:28) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.filter.block.CharFilterBlock.filter(CharFilterBlock.java:176) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.regions.Region.filter(Region.java:326) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.regions.Region.filter(Region.java:309) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.sk89q.worldedit.regions.CuboidRegion.filter(CuboidRegion.java:761) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.extent.filter.block.ChunkFilterBlock.filter(ChunkFilterBlock.java:88) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.queue.implementation.chunk.ChunkHolder.filterBlocks(ChunkHolder.java:914) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.queue.IQueueExtent.apply(IQueueExtent.java:167) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at com.fastasyncworldedit.core.queue.implementation.ParallelQueueExtent.lambda$apply$0(ParallelQueueExtent.java:178) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
        at java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1403) ~[?:?]
        at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387) ~[?:?]
        at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312) ~[?:?]
        at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843) ~[?:?]
        at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808) ~[?:?]
        at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188) ~[?:?]

It doesn't update everything

[18:05:25 INFO]: jenscraft_MC issued server command: //fixconnect [18:05:25 ERROR]: An unexpected error while handling a FastAsyncWorldEdit command java.lang.NullPointerException: null

dordsor21 · 2024-07-13T15:27:23Z

Fixed^

VL4DST3R · 2024-07-13T20:18:18Z

Fixed^

Came here for both of the same reasons as the user above but encountered a different issue when trying to use it (it did not work).

23:16:45 [SEVERE] An unexpected error while handling a FastAsyncWorldEdit command
23:16:45 java.lang.NullPointerException: Cannot invoke "com.sk89q.worldedit.world.block.BlockType.getInternalId()" because "type" is null
23:16:45 	at com.sk89q.worldedit.function.mask.BlockTypeMask.add(BlockTypeMask.java:105) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.fastasyncworldedit.core.extent.processor.PlacementStateProcessor.setup(PlacementStateProcessor.java:164) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.fastasyncworldedit.core.extent.processor.PlacementStateProcessor.<init>(PlacementStateProcessor.java:87) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R1.PaperweightPlacementStateProcessor.<init>(PaperweightPlacementStateProcessor.java:31) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.sk89q.worldedit.bukkit.adapter.impl.fawe.v1_20_R1.PaperweightFaweAdapter.getPlatformPlacementProcessor(PaperweightFaweAdapter.java:617) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.sk89q.worldedit.bukkit.BukkitServerInterface.getPlatformPlacementProcessor(BukkitServerInterface.java:319) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.sk89q.worldedit.command.RegionCommands.fixblocks(RegionCommands.java:914) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.sk89q.worldedit.command.RegionCommandsRegistration.cmd$_fixblocks(RegionCommandsRegistration.java:1034) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at org.enginehub.piston.CommandManager.execute(CommandManager.java:157) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:45 	at com.sk89q.worldedit.extension.platform.PlatformCommandManager.lambda$handleCommandOnCurrentThread$16(PlatformCommandManager.java:727) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at com.sk89q.worldedit.extension.platform.PlatformCommandManager.handleCommandTask(PlatformCommandManager.java:748) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at com.sk89q.worldedit.extension.platform.PlatformCommandManager.handleCommandOnCurrentThread(PlatformCommandManager.java:729) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at com.sk89q.worldedit.extension.platform.PlatformCommandManager.lambda$handleCommand$14(PlatformCommandManager.java:700) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at com.sk89q.worldedit.extension.platform.AbstractPlayerActor.lambda$runAction$1(AbstractPlayerActor.java:672) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at com.fastasyncworldedit.core.util.task.AsyncNotifyKeyedQueue.lambda$run$0(AsyncNotifyKeyedQueue.java:48) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at com.fastasyncworldedit.core.util.task.AsyncNotifyKeyedQueue.lambda$call$1(AsyncNotifyKeyedQueue.java:58) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at java.util.concurrent.FutureTask.run(FutureTask.java:317) ~[?:?]
23:16:46 	at com.fastasyncworldedit.core.util.task.KeyQueuedExecutorService$KeyRunner.lambda$run$0(KeyQueuedExecutorService.java:150) ~[FastAsyncWorldEdit-Bukkit-2.11.1-SNAPSHOT.jar:?]
23:16:46 	at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.compute(ForkJoinTask.java:1726) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.compute(ForkJoinTask.java:1717) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinTask$InterruptibleTask.exec(ForkJoinTask.java:1641) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:507) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1491) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:2073) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2035) ~[?:?]
23:16:46 	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187) ~[?:?]

Is this there a build of this available to download somewhere?

github-actions · 2024-07-21T07:22:14Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2024-09-17T15:55:02Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

github-actions · 2024-09-20T22:12:53Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

VL4DST3R · 2024-09-23T15:19:09Z

Hey just wanted to let you know that the latest (as of me writing) pr artifact does not preserve upside-down stairs properly, everything else seems to work great!

github-actions · 2024-09-25T17:23:03Z

Please take a moment and address the merge conflicts of your pull request. Thanks!

dordsor21 · 2024-10-26T16:40:16Z

Hey just wanted to let you know that the latest (as of me writing) pr artifact does not preserve upside-down stairs properly, everything else seems to work great!

This has been fixed

- closes #313

…lock updates

dordsor21 requested a review from a team as a code owner May 26, 2024 16:30

github-actions bot added Bugfix This PR fixes a bug Feature This PR adds a new feature labels May 26, 2024

dordsor21 removed the Bugfix This PR fixes a bug label May 26, 2024

PierreSchwang reviewed May 26, 2024

View reviewed changes

...core/src/main/java/com/fastasyncworldedit/core/extent/processor/PlacementStateProcessor.java Show resolved Hide resolved

github-actions bot added the Bugfix This PR fixes a bug label May 26, 2024

dordsor21 marked this pull request as draft May 27, 2024 19:35

dordsor21 marked this pull request as ready for review May 31, 2024 19:42

dordsor21 requested a review from a team May 31, 2024 19:43

dordsor21 mentioned this pull request Jun 2, 2024

requesting Perf validation #2493

Open

dordsor21 requested a review from PierreSchwang June 9, 2024 13:31

github-actions bot added the unresolved-merge-conflict label Jun 10, 2024

github-actions bot removed the unresolved-merge-conflict label Jun 10, 2024

github-actions bot added the unresolved-merge-conflict label Jun 20, 2024

github-actions bot added unresolved-merge-conflict and removed unresolved-merge-conflict labels Jun 21, 2024

github-actions bot removed the unresolved-merge-conflict label Jun 27, 2024

github-actions bot added the unresolved-merge-conflict label Sep 17, 2024

dordsor21 force-pushed the feat/block-connections-updates branch from 3b57cbd to 164e5c6 Compare September 17, 2024 19:48

github-actions bot added unresolved-merge-conflict and removed unresolved-merge-conflict labels Sep 17, 2024

dordsor21 force-pushed the feat/block-connections-updates branch from 164e5c6 to 27f56de Compare September 20, 2024 22:17

github-actions bot removed the unresolved-merge-conflict label Sep 20, 2024

github-actions bot added the unresolved-merge-conflict label Sep 25, 2024

dordsor21 force-pushed the feat/block-connections-updates branch from 9bcdc7f to 5b1c7e0 Compare September 29, 2024 10:52

github-actions bot removed the unresolved-merge-conflict label Sep 29, 2024

dordsor21 force-pushed the feat/block-connections-updates branch from 5b1c7e0 to 26030b2 Compare October 26, 2024 09:53

dordsor21 added 14 commits November 16, 2024 11:10

feat: implement command to fix block connections

eb13872

- closes #313

set SETUP to true on setup

cf68c74

Add (untested) processing capability and second passes where appropriate

3fbd969

Minor refactor, add various javadocs

a38feba

Minor adjustments

c2c09b1

Better chest handling

4ae6b85

Utilise thread extends when able

cb55dca

Add strings, changes to fastmode/side effect handling

077c4d3

Cleanup

5208cd1

Add for 1.21

f0f9316

Adjustment for tall flowers - add capability to forcefully override b…

aa63677

…lock updates

Move to Fawe/LinTag

697156f

fix: adjustments, fix certain upside-down blocks

57f8f6c

Add for 1.21.3

5460b5f

dordsor21 force-pushed the feat/block-connections-updates branch from b3bfe79 to 5460b5f Compare November 16, 2024 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement command to fix block connections #2746

feat: implement command to fix block connections #2746

dordsor21 commented May 26, 2024

dordsor21 commented May 26, 2024

PierreSchwang commented May 27, 2024

dordsor21 commented May 27, 2024

github-actions bot commented Jun 10, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

AGuyNamedJens commented Jul 10, 2024

dordsor21 commented Jul 10, 2024

AGuyNamedJens commented Jul 10, 2024 •

edited

Loading

dordsor21 commented Jul 13, 2024

VL4DST3R commented Jul 13, 2024

github-actions bot commented Jul 21, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 20, 2024

VL4DST3R commented Sep 23, 2024 •

edited

Loading

github-actions bot commented Sep 25, 2024

dordsor21 commented Oct 26, 2024 •

edited

Loading

feat: implement command to fix block connections #2746

Are you sure you want to change the base?

feat: implement command to fix block connections #2746

Conversation

dordsor21 commented May 26, 2024

dordsor21 commented May 26, 2024

PierreSchwang commented May 27, 2024

dordsor21 commented May 27, 2024

github-actions bot commented Jun 10, 2024

github-actions bot commented Jun 20, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

AGuyNamedJens commented Jul 10, 2024

dordsor21 commented Jul 10, 2024

AGuyNamedJens commented Jul 10, 2024 • edited Loading

dordsor21 commented Jul 13, 2024

VL4DST3R commented Jul 13, 2024

github-actions bot commented Jul 21, 2024

github-actions bot commented Sep 17, 2024

github-actions bot commented Sep 20, 2024

VL4DST3R commented Sep 23, 2024 • edited Loading

github-actions bot commented Sep 25, 2024

dordsor21 commented Oct 26, 2024 • edited Loading

AGuyNamedJens commented Jul 10, 2024 •

edited

Loading

VL4DST3R commented Sep 23, 2024 •

edited

Loading

dordsor21 commented Oct 26, 2024 •

edited

Loading