Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend docs for qualified names by new features from #477 #478

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zsol
Copy link
Member

@zsol zsol commented Apr 19, 2021

Summary

Documentation changes.

Test Plan

look at the generated docs

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #478 (ee34e13) into master (068b905) will decrease coverage by 0.00%.
The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   94.68%   94.68%   -0.01%     
==========================================
  Files         236      236              
  Lines       22978    23013      +35     
==========================================
+ Hits        21757    21790      +33     
- Misses       1221     1223       +2     
Impacted Files Coverage Δ
libcst/metadata/scope_provider.py 95.72% <90.00%> (-0.22%) ⬇️
libcst/metadata/tests/test_name_provider.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068b905...ee34e13. Read the comment docs.

@zsol
Copy link
Member Author

zsol commented Apr 19, 2021

Copy link
Contributor

@jimmylai jimmylai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zsol , regarding to your comments on #477,
do you still plan to provide QualifiedName for imports and update RenameCommand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants