weather: Add function for converting to units

[FintasticMan]

Handles rounding correctly.

[github-actions]

Build size and comparison to main:

Section	Size	Difference
text	373224B	-16B
data	940B	0B
bss	63516B	0B

[vkareh]

I think this name is not quite representative, since it doesn't include units. Maybe something like "RenderTemp" or "DisplayTemp" or "RoundTemp"? Not entirely sure, naming is hard :/

Other than that, I really like what you're doing centralizing this function.

[minacode]

What is the meaning of the input and output?

[FintasticMan]

The input is a temperature in units multiplied by 100, and the output is temperature in the actual unit. I wasn't sure of the naming either, it's a surprisingly difficult operation to give a name to.

[minacode]

So it's basically FixedPoint2ToIntRounded? 😄

[FintasticMan]

CentiToUnit? As in centicelsius to celsius or centifahrenheit to fahrenheit.

[JF002]

This method could simply be called Convert() if we used strong types for arguments. Ex:

static DisplayTemperature Convert(const SimpleWeatherService::RawTemperature temperature)

Using stronger types for

• temperature coming from the weather service (in "centi celsius degrees")
• temperature in °C
• temperature in °F

Would probably help with code readability.

[FintasticMan]

Just done something like that. I decided not to distinguish between the temperature in C or in F. Do you think this makes sense?

[minacode]

You could use structs of one int to make the types really safe.

[JF002]

I'm ok with the current state. I however thought about another option.

SimpleWeatherService would define a Temperature type : PineTime::Controllers::SimpleWeatherService::Temperature. It's the internal representation of a temperature in the SompleWeatherService expressed in "°C * 100"

struct Temperature {
  int16_t temperature;
}

Somewhere under DisplayApp, we would define another Temperature type : Pinetime::Applications::Temperature. It represent the temperature for the UI side of InfiniTime as an std::variant (TODO : check that the overhead of std::variant is negligible)

struct TemperatureCelsius {
  int16_t temperature;
}

struct TemperatureFahrenheit {
  int16_t temperature;
}

using Temperature = std::variant<TemperatureCelsius, TemperatureFahrenheit temperature

Then, also under DisplayApp, we define a function that converts from SimpleWeatherService Temperature to "display" temperature :

Pinetime::Applications::Temperature Convert(PineTime::Controllers::SimpleWeatherService::Temperature, Controllers::Settings::WeatherFormat format);

This way, all the "temperature" types are strongly typed and it's impossible to implicitly convert from one to another. Also SimpleWeatherService does not have any code related to the UI anymore.