Themes: Refactor Checkbox, Switch, and Radio #14232
Conversation
simeonoff
added
switch
checkbox
❌ status: awaiting-test
|
Material All good with material -> the invalid variants ripple color is already fixed thanks to @didimmova |
|
Fluent There is some visual glitch in Fluent Checkbox/Intermediate. -> this is fixed ✅ https://github.com/IgniteUI/igniteui-angular/assets/127843837/d88d729f-1f5e-4099-9096-b78da1e5a4ae In addition, while hovering a list item with a disabled checkbox in dark mode, the checkbox is not visible, but we will fix this during the List component refinement. This is because the checkbox disabled color is the same as the list item hover/active background color. |
|
|
||
| @if $variant == 'bootstrap' and $theme-variant == 'dark' { | ||
| %cbx-composite-mark { | ||
| stroke: black; |
There was a problem hiding this comment.
Why are you using a hardcoded color?
There was a problem hiding this comment.
same reason, no need to expose new property, since it's different only in dark bootstrap theme
|
Bootstrap |
This comment was marked as resolved.
This comment was marked as resolved.
didimmova
added
✅ status: verified
Closes #14107
Closes #14108
Closes #14109
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)