[Lynx] Workaround a runtime bug not reporting tracked hand positions #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lynx runtime never returns the XR_SPACE_LOCATION_POSITION_TRACKED_BIT flag as active, even if it's really actively tracking the position of the hands. That confused the code and made it think that emulated positions were returned instead. That was causing the origin of the aim pose (and thus the origin of the aim ray) to be incorrectly shifted from the hands. The workaround is replacing the check for POSITION_TRACKED_BIT by POSITION_VALID_BIT. That way we'd still be able to detected when hands are not tracked while providing a much better aim.
|
Before (note how the ray origin is way bellow the hand): After: |
javifernandez
approved these changes
Jan 15, 2025
javifernandez
approved these changes
Jan 15, 2025
javifernandez
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lynx runtime never returns the XR_SPACE_LOCATION_POSITION_TRACKED_BIT flag as active, even if it's really actively tracking the position of the hands. That confused the code and made it think that emulated positions were returned instead.
That was causing the origin of the aim pose (and thus the origin of the aim ray) to be incorrectly shifted from the hands. The workaround is replacing the check for POSITION_TRACKED_BIT by POSITION_VALID_BIT. That way we'd still be able to detected when hands are not tracked while providing a much better aim.