Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show builtin extensions (addons) in the hamburger menu #1668

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

svillar
Copy link
Member

@svillar svillar commented Jan 7, 2025

Wolvic uses builtin extensions (not user installable) for several matters, from better YouTube experiences to workarounding issues in media playing. Those builtin addons are not user installable and they can't be disabled or uninstalled either. Actually the point is to make them completely transparent to the users. That's why we should not show them in the hamburger menu.

Wolvic uses builtin extensions (not user installable) for several matters,
from better YouTube experiences to workarounding issues in media playing.
Those builtin addons are not user installable and they can't be disabled
or uninstalled either. Actually the point is to make them completely
transparent to the users. That's why we should not show them in the
hamburger menu.
Copy link
Collaborator

@felipeerias felipeerias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

@svillar svillar merged commit e3163f0 into main Jan 8, 2025
22 checks passed
@svillar svillar deleted the filter_addons_ui branch January 8, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants