Write window state to disk on diskIO thread #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
force-pushed
the
write_file_diskio
branch
from
6c7136b to
07130ec
Compare
The saveState() method from Windows class was writing its state in the main thread. This kind of blocking operations should not be done in the main thread. This was detected using strict mode.
svillar
force-pushed
the
write_file_diskio
branch
from
07130ec to
f8b6829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The saveState() method from Windows class was writing its state in the main thread. This kind of blocking operations should not be done in the main thread. This was detected using strict mode.