Enable haptic feedback for controllers #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HollowMan6
requested review from
svillar,
javifernandez,
felipeerias and
elima
javifernandez
previously requested changes
Oct 18, 2023
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/ControllerOptionsView.java
Outdated
Show resolved
Hide resolved
svillar
requested changes
Oct 23, 2023
app/src/common/shared/com/igalia/wolvic/ui/widgets/settings/ControllerOptionsView.java
Outdated
Show resolved
Hide resolved
HollowMan6
force-pushed
the
haptic-feedback
branch
from
77aa073 to
1488478
Compare
svillar
requested changes
Oct 27, 2023
HollowMan6
force-pushed
the
haptic-feedback
branch
2 times, most recently
from
7818a04 to
5882e2e
Compare
Now we also have this disabled by default |
svillar
requested changes
Oct 30, 2023
Users can also disable the haptic feedback in controller settings. Resolves #1067 Signed-off-by: Songlin Jiang <[email protected]>
Signed-off-by: Songlin Jiang <[email protected]>
Signed-off-by: Songlin Jiang <[email protected]>
HollowMan6
force-pushed
the
haptic-feedback
branch
from
5882e2e to
9925ec0
Compare
svillar
dismissed
javifernandez’s stale review
Javi's concerns will be addressed in a follow up as agreed in the review process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haptic feedback will be triggered when:
MotionEvent.ACTION_HOVER_ENTERUsers can disable the haptic feedback in controller settings.
Resolves #1067
