Overload DatasetField method to remove type check #9010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spotted a TODO near a type check based on a string comparison of the class name.
Both `copy(DatasetVersion)` and `copy(Template)` still refer to `copy(Object, DatasetFieldCompoundValue)`, because copying that method would make the code less DRY.
|
@sekmiller could you have a look at this? I think this was your code. |
|
I just noticed that there actually was an issue that this PR closes: #1240 (I edited the PR description accordingly). Perhaps @scolapasta could have a look at this PR, since he opened the issue many years ago? |
pdurbin
added
Size: 3
sekmiller
approved these changes
Jul 17, 2024
|
Looks good. Built and tested locally. Automated tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It replaces a method that did a string comparison on the class name of an
Objectparameter to determine what to do by two methods that have the expected parameter types.This improves type safety by allowing the compiler to check types.
Which issue(s) this PR closes:
Closes #1240, removes a TODO from the codebase and relates to #9021.
Special notes for your reviewer:
I added a few basic unit tests so that the coverage doesn't decrease with the new methods.
Suggestions on how to test this:
Please check that the logic of the new tests makes sense and that they pass like the existing unit tests.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation: