add wait to async export call #11033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwinship
added
Type: Bug
qqmyers
requested changes
Nov 18, 2024
| // http://localhost:8080/api/datasets/export?exporter=dataverse_json&persistentId=doi%3A10.5072/FK2/W6WIMQ | ||
| RequestSpecification requestSpecification = given(); | ||
| if (apiToken != null) { | ||
| requestSpecification = given() | ||
| .header(UtilIT.API_TOKEN_HTTP_HEADER, apiToken); | ||
| } | ||
| return requestSpecification | ||
| Response resp = requestSpecification |
There was a problem hiding this comment.
This only needs to be called once, after waiting if wait=true.
| // http://localhost:8080/api/datasets/export?exporter=dataverse_json&persistentId=doi%3A10.5072/FK2/W6WIMQ | ||
| RequestSpecification requestSpecification = given(); | ||
| if (apiToken != null) { | ||
| requestSpecification = given() | ||
| .header(UtilIT.API_TOKEN_HTTP_HEADER, apiToken); | ||
| } | ||
| return requestSpecification | ||
| Response resp = requestSpecification | ||
| // .header(API_TOKEN_HTTP_HEADER, apiToken) |
There was a problem hiding this comment.
removed commented out code
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
Merging PR monitoring Jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Sporadic test failures in DatasetsIT due to not waiting for an asynchronous call to finish
Which issue(s) this PR closes:#11032
Special notes for your reviewer:
Suggestions on how to test this: See IT tests. Monitor Jenkins for failures after merging
Does this PR introduce a user interface change? If mockups are available, please link/include them here:No
Is there a release notes update needed for this change?:No
Additional documentation:No