Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade docker maven plugin to 0.45 #10730

Merged
merged 1 commit into from
Jul 29, 2024
Merged

upgrade docker maven plugin to 0.45 #10730

merged 1 commit into from
Jul 29, 2024

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jul 29, 2024

What this PR does / why we need it:

Lower versions don't work on Mac

Which issue(s) this PR closes:

Special notes for your reviewer:

None.

Suggestions on how to test this:

This is how I tested it:

mvn -Pct -f modules/container-base clean package -Dbase.image.tag=9771
mvn -Pct clean package docker:run -Dbase.image.tag=9771

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

No.

Additional documentation:

No.

lower versions don't work on Mac
@pdurbin pdurbin added Size: 0.5 A percentage of a sprint. 0.35 hours Component: Containers Anything related to cloudy Dataverse, shipped in containers. labels Jul 29, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.663%. remained the same
when pulling 944c405 on 9771-driver
into 650003e on develop.

@poikilotherm
Copy link
Contributor

Looks good to me! Builds on Fedora, builds in CI, builds on Mac ARM64, let's go!

@poikilotherm poikilotherm merged commit c39ac88 into develop Jul 29, 2024
14 of 15 checks passed
@poikilotherm poikilotherm deleted the 9771-driver branch July 29, 2024 13:51
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9771-driver
ghcr.io/gdcc/configbaker:9771-driver

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin pdurbin added this to the 6.4 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Containers Anything related to cloudy Dataverse, shipped in containers. Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

DOCKER> unknown flag: --driver with M1 Mac
3 participants