Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding sql script to convert custom license CC0 Waiver to CC0 1.0 #10634

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

stevenwinship
Copy link
Contributor

What this PR does / why we need it: The update from pre-v5.10 to 5.10+ adjusts the terms metadata of datasets in the installation. The datasets that have a CC0 waiver plus text in any other field in the old "Terms of Use" accordion are considered to have "custom licenses". But some datasets with CC0 waivers and no text in fields in the old "Terms of Use" accordions also appear, after the update, to have "custom licenses", such as https://doi.org/10.7910/DVN/00ROYZ and https://doi.org/10.15787/h6vv-ts37. The only text in the custom license is "CC0 waiver":

Which issue(s) this PR closes:Multiple license update turned the terms of some datasets with only CC0 licenses into "custom licenses" #9081

Closes #9081

Special notes for your reviewer:

Suggestions on how to test this: SQL Script

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: Yes. Included

Additional documentation:

@stevenwinship stevenwinship added Type: Bug a defect Feature: Terms & Licensing Size: 10 A percentage of a sprint. 7 hours. labels Jun 17, 2024
@stevenwinship stevenwinship self-assigned this Jun 17, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.659%. remained the same
when pulling 71098cb on 9081-CC0-waiver-turned-into-custom-license
into 00020e2 on develop.

@@ -0,0 +1,10 @@
UPDATE termsofuseandaccess SET license_id = (SELECT license.id FROM license WHERE license.name = 'CC0 1.0'), termsofuse = 'CC0 Waiver'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

termsofuse should be null after the update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be nice to be able to find the ones changed after the fact. There are many rows with termsofuse not null with license_id set. I can change it if you want.

Copy link
Member

@qqmyers qqmyers Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - in the UI if you have something in terms of use and select a license, the terms of use are nulled. I don't think there should be a way to have a license and terms of use or related fields- the terms of use aren't displayed when a license is in use. (Terms of Access and fields related to that are fine). I'd suggest putting null in with this PR and perhaps opening an issue to address any other cases that exist (legacy and if there's a way to create new datasets with a license and terms of use we should close that hole.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to null

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Jun 17, 2024
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@coveralls
Copy link

Coverage Status

coverage: 20.659%. remained the same
when pulling 116262c on 9081-CC0-waiver-turned-into-custom-license
into 00020e2 on develop.

@coveralls
Copy link

Coverage Status

coverage: 20.659%. remained the same
when pulling 116262c on 9081-CC0-waiver-turned-into-custom-license
into 00020e2 on develop.

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:9081-CC0-waiver-turned-into-custom-license
ghcr.io/gdcc/configbaker:9081-CC0-waiver-turned-into-custom-license

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Terms & Licensing Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
Status: Ready for QA ⏩
Development

Successfully merging this pull request may close these issues.

Multiple license update turned the terms of some datasets with only CC0 licenses into "custom licenses"
3 participants