adding fix to file name for download guestbook responses #10613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwinship
added
Type: Bug
This comment has been minimized.
This comment has been minimized.
pdurbin
reviewed
Jun 5, 2024
| @@ -220,7 +220,8 @@ private String getFileName(){ | |||
| // The fix below replaces any spaces in the name of the dataverse with underscores; | |||
| // without it, the filename was chopped off (by the browser??), and the user | |||
| // was getting the file name "Foo", instead of "Foo and Bar in Social Sciences.csv". -- L.A. | |||
| return dataverse.getName().replace(' ', '_') + "_GuestbookReponses.csv"; | |||
| // Also removing some chars that have been reported to cause issues with certain browsers | |||
| return dataverse.getName().replace(' ', '_').replaceAll("[\\\\/:*?\"<>|,;]", "") + "_GuestbookResponses.csv"; | |||
There was a problem hiding this comment.
Since these two regex's are the same, should they be defined once as a constant?
Also, can we have some tests?
There was a problem hiding this comment.
They're in 2 different classes.
There was a problem hiding this comment.
And neither of these classes have any tests :(
There was a problem hiding this comment.
moving this method to FileUtil and adding tests
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
qqmyers
approved these changes
Jun 26, 2024
sekmiller
deleted the
9401-fix-truncated-collection-name-guestbook-csv-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Chrome browser to download the guestbook of a Dataverse collection that has a comma in the collection's name, such as the collection named "Representation, Treatment, Outcome" the file name is truncated to Representation.
Closes #9401
Special notes for your reviewer:
Suggestions on how to test this: test by creating a collection with commas in the name and setting up guestbook. Then, download using Chrome, Safari, and Firefox.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: No
Additional documentation: Also removes other chars that could cause issues when used in a file name.