removed gel_layer_height in simulate_3D.m #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually removing dx * GEL_LAYER_HEIGHT completely can place the sensors outside of the volume. To avoid this we need to add at least dx. But then we should probably add it to all directions. |
|
Yes, I guess we should add it to all directions probably in both |
kdreher
requested changes
Jun 26, 2024
Comment on lines
+103
to
105
| elem_pos(1, :) = elem_pos(1, :) - 0.5 * kgrid.x_size; | ||
| elem_pos(2, :) = elem_pos(2, :) - 0.5 * kgrid.y_size; | ||
| elem_pos(3, :) = elem_pos(3, :) - 0.5 * kgrid.z_size; |
There was a problem hiding this comment.
Add dx for all directions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following before creating the pull request (PR):
Provide issue / feature request fixed by this PR
Fixes #237
For now removed the gel_layer_height in the calculation of the element positions, because the gel layer is never padded to the arrays.