Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use process unique file naming for kwave files #234

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

jnoelke
Copy link
Collaborator

@jnoelke jnoelke commented Aug 4, 2023

Fixes #215

We provide a name for the temporary kwave files. Previously, a default naming convention was used internally (only based on the current time) which could cause problems when running multiple instances.

Copy link
Collaborator

@TomTomRixRix TomTomRixRix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these two comments the contribution looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file naming of temporary kwave input and output .h5 -files leads to error in multiprocessed scripts
4 participants