Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overwriting services #15

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stephenwf
Copy link
Member

When a resource is dereferenced and loaded the body is passed through a step where the auth is extracted. This ensures that if there were services embedded in the manifest but not in the dereferenced resource they are not overwritten. Added tests to cover the previously working BL AV manifest and the new structure with a change in where the probe service resides.

@stephenwf stephenwf requested a review from edsilv March 10, 2021 19:39
@stephenwf
Copy link
Member Author

Tests are expected to fail until IIIF-Commons/manifesto#89 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant