Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvasworld #83

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Canvasworld #83

wants to merge 7 commits into from

Conversation

edsilv
Copy link
Member

@edsilv edsilv commented Dec 7, 2020

Created CanvasWorld.ts

  • use types for ViewingDirection, added OA_CHOICE to @iiif/vocabulary
  • added normalize-url. Can we use that instead of Utils.normaliseUrl ?

Added imageResources, aspectRatio, onFragment, resourceAnnotation, resourceAnnotations to Canvas.ts

  • shall we make all methods getters in manifesto now?
  • added lodash flatten and flattenDeep deps
  • shall we aim for parity with MiradorCanvas so Mirador can just use Canvas?

@mejackreed
Copy link
Contributor

Just as a heads up, I wanted to call out some issues that @jbaiter noticed and is still in progress on working on. ProjectMirador/mirador#3356

These only come up in multi-canvas views with scaled pages having annotations.

@edsilv
Copy link
Member Author

edsilv commented Dec 8, 2020

I'm publishing 4.3.0-pre-0 - if I install it locally to test using the github namespace the UV project can't resolve it :-(

@edsilv edsilv requested a review from stephenwf December 8, 2020 15:17
@stephenwf
Copy link
Member

I don't think you can use the github namespace if it's not built. You can use npm link in manifesto.js and then npm link manifesto.js in the UV to test locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants