Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 9 merge in context jsonld to registration schema #12

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Issue 9 merge in context jsonld to registration schema #12

wants to merge 10 commits into from

Conversation

jesserobertson
Copy link

Working on fix for #9

Jess Robertson added 4 commits June 6, 2020 15:11
👩‍💻 Making @id tag required for document
7924da3 
Tests are going to crap themselves now
🧪 Injecting @id tags
ba29f92 
@id tags now required in registration schema
🧪 Change JSON-LD context injection
a0681eb 
Now we point to the master version so that branches don't randomly fail
on schema checks because the contstant value is wrong...

To fix properly we will need to do schema generation from templates,
but this is a job for another day
✍ Updated examples to satisfy new schema
98241f6 
Now include @id tags as required
@jesserobertson jesserobertson linked an issue Jun 6, 2020 that may be closed by this pull request
Merge in context.jsonld to registration schema #9
Open
5 tasks
@jesserobertson jesserobertson added enhancement New feature or request schema Issues related to JSONSchema labels Jun 6, 2020
@jesserobertson jesserobertson marked this pull request as draft June 6, 2020 03:28
@jesserobertson jesserobertson changed the title WIP: Issue 9 merge in context jsonld to registration schema Issue 9 merge in context jsonld to registration schema Jun 6, 2020
@jesserobertson jesserobertson self-assigned this Jun 6, 2020
@dr-shorthair
Copy link

Jess - I'd like to review these, but I don't work in JSON.
Assuming that they were all intended to be valid JSON-LD I attempted to load them in an RDF environment. While they don't throw any errors, they also don't show any content.
It is probably because there is a schema/ontology to import. I tried to load the registration schema but hit the same wall.

At this point I have to give up as I have other priorities today. If you could get them functioning as proper JSON-LD or give me some instructions I'll be glad to review.

@jesserobertson
Copy link
Author

Oh hey sorry didn’t mean for this to be reviewed until out of draft stage.

Did you both get notifications once I add as a reviewer? I will be a little less quick off the mark next time.

@jesserobertson
Copy link
Author

But yes the plan was to provide instructions for review as well - apologies if your time feels a little wasted

@dr-shorthair
Copy link

Did you both get notifications once I add as a reviewer?

Yeah - I think as soon as you mention any GitHub ID, they get a notification mail.

@jesserobertson
Copy link
Author

Ok - it seems you are both victims of my cluelessness at GitHub’s UI. 🤦‍♂️

I’ll let you know when this is ready for review.

Jess Robertson added 2 commits June 9, 2020 11:05
📦 Add pyld to dependencies
6e138c6
🧪Factor helper functions out
93c90e2 
helpers for getting examples now moved to seperate helper module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-shorthair dr-shorthair Awaiting requested review from dr-shorthair

@fils fils Awaiting requested review from fils

Assignees

@jesserobertson jesserobertson

Labels
enhancement New feature or request schema Issues related to JSONSchema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge in context.jsonld to registration schema
2 participants
@jesserobertson @dr-shorthair