Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility: arecord, iscreenshot + add apowerbutton #229

Merged
merged 14 commits into from
Dec 17, 2024
Merged

Fix compatibility: arecord, iscreenshot + add apowerbutton #229

merged 14 commits into from
Dec 17, 2024

Conversation

IGPenguin
Copy link
Owner

@IGPenguin IGPenguin commented Oct 17, 2024 •
edited
Loading

⚠️ Progress checklist

  • 🏗 Features fully completed
    • arecord fixed on latest scrcpy
    • apowerbutton
    • iscreenshot fixed on iOS 17+
    • mitigate iscreenshot delays when re-trying various ports
    • Improve iOS device availabilty error (remove unnecessary reconnect prompt)
  • 🔬 Shellcheck issues resolved
  • 🔨 All changes tested
  • 💬 Terminal output satisfactory
    • Remove random JSONs coming from go-ios (in some cases)
  • 👀 Diff examined thoroughly
  • 📝 API changes included in README.md
  • 📣 Major changes listed in changelog.txt

@IGPenguin IGPenguin requested a review from vrbajiva October 17, 2024 18:02
@IGPenguin IGPenguin self-assigned this Oct 17, 2024
@IGPenguin IGPenguin added enhancement existing functionality extension new feature idea for new feature labels Oct 17, 2024
@vrbajiva
Copy link
Collaborator

vrbajiva commented Oct 21, 2024 •
edited
Loading

iscreenshot returning error

Error:

{"level":"warning","msg":"failed to get tunnel info","time":"2024-10-21T13:51:09+02:00","udid":"00008110-000620DC2E52401E"}
📸 Saving screenshot into Apple-iPhone13ProMax-iOS17.3-2024-10-21-13-51-09.png...
🤷 Screenshot failed, error code: 1

Device info:
iPhone 13 Pro Max running iOS 17.3

Additional info:

  • iOS 18.0.1 -> OK
  • iOS 17.7 -> OK

@IGPenguin
Copy link
Owner Author

IGPenguin commented Dec 17, 2024 •
edited
Loading

Merging now, please do scream at me if something goes horribly wrong. 🤘

@IGPenguin IGPenguin merged commit 491c778 into master Dec 17, 2024
2 checks passed
@IGPenguin IGPenguin deleted the feature/compatiblity-fixes branch December 17, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrbajiva vrbajiva Awaiting requested review from vrbajiva

Assignees

@IGPenguin IGPenguin

Labels
enhancement existing functionality extension new feature idea for new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGPenguin @vrbajiva @luispinho