Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the CI configuration and significant enhancements to the unit tests for the MMD data drift detector. The most important changes include updating the macOS version in the CI workflow and adding comprehensive tests for various chunk sizes and kernels in the
test_mmd.py
file.CI Configuration Update:
.github/workflows/ci.yml
: Updated the macOS version frommacos-12
tomacos-14
to ensure compatibility with newer macOS environments.Enhancements to Unit Tests:
frouros/tests/unit/detectors/data_drift/batch/distance_based/test_mmd.py
: Added constantsRANDOM_SEED
andDEFAULT_SIGMA
for better maintainability and replaced hardcoded values with these constants in existing tests. [1] [2] [3]frouros/tests/unit/detectors/data_drift/batch/distance_based/test_mmd.py
: Introduced new tests to check the equivalence of MMD results with different chunk sizes and to verify the validity of chunk sizes and kernels.