-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Get PCI Devices for Windows and Linux, Rename White Color #38
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR! I was hoping we could better format the stdout, this take up my entire screen :(
What about formatting it into a sort of table to improve readability? @DarthBenro008
I had to do some research, I feel this could be more optimised, we need to come up some kind of priority class to display only some devices info first, this full list could be a accessed by a separate flag command. @aryan9600 i don't think a table would help in listing out PCI devices. |
Yeah a verbose flag makes sense to me. Basically wanted to avoid the output taking up the entire screen xD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation looks good, we can separate it out to a new flag.
@DarthBenro008 @aryan9600 Please review it, and let me know if there are any changes. |
Partially Fixes: ls* Family Issue
What's new
Usage
To see the output of PCI Devices:
do as
./termiboard.exe -pci-devices
Reference Docs:
For Windows: Win32_PNPEntity and to query it: StackExchange/wmi pkg
For Linux: jaypipes/ghw pkg