Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get PCI Devices for Windows and Linux, Rename White Color #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sjchoure
Copy link
Contributor

@sjchoure sjchoure commented Oct 2, 2020

Partially Fixes: ls* Family Issue

What's new

  • Added Get PCI Devices Function For Windows and Linux
  • Renamed White Color to match other colors name

Usage

To see the output of PCI Devices:
do as
./termiboard.exe -pci-devices

Reference Docs:

  1. For Windows: Win32_PNPEntity and to query it: StackExchange/wmi pkg

  2. For Linux: jaypipes/ghw pkg

@sjchoure sjchoure marked this pull request as draft October 2, 2020 15:39
@sjchoure sjchoure marked this pull request as ready for review October 2, 2020 15:47
@sjchoure sjchoure marked this pull request as draft October 2, 2020 16:01
@sjchoure sjchoure marked this pull request as ready for review October 2, 2020 16:04
Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! I was hoping we could better format the stdout, this take up my entire screen :(
What about formatting it into a sort of table to improve readability? @DarthBenro008

@DarthBenro008
Copy link
Member

I had to do some research, I feel this could be more optimised, we need to come up some kind of priority class to display only some devices info first, this full list could be a accessed by a separate flag command. @aryan9600 i don't think a table would help in listing out PCI devices.

@aryan9600
Copy link
Member

Yeah a verbose flag makes sense to me. Basically wanted to avoid the output taking up the entire screen xD

Copy link
Member

@DarthBenro008 DarthBenro008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation looks good, we can separate it out to a new flag.

go.mod Outdated Show resolved Hide resolved
@sjchoure sjchoure changed the title Add Get PCI Devices, Add Bold Green Color, Rename White Color Add Get PCI Devices for Windows and Linux, Rename White Color Oct 4, 2020
@sjchoure
Copy link
Contributor Author

sjchoure commented Oct 4, 2020

@DarthBenro008 @aryan9600 Please review it, and let me know if there are any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants