Parametrise number of top ps #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulwsztyn
changed the title
Vulwsztyn
force-pushed
the
parametrise_number_of_top_ps
branch
from
ed95683 to
5aa7e92
Compare
Vulwsztyn
changed the title
DarthBenro008
requested changes
Oct 2, 2020
Comment on lines
+92
to
101
| for i := 0; i < howManyProcessesToShow; i++ { | ||
| memoryPercentOfIthProcess, err := processes[i].MemoryPercent() | ||
| if err != nil { | ||
| StandardPrinter(ErrorRedColor, "Process memory usage access denied.") //More descriptive error | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
You need to handle out of range cases in this loop
There was a problem hiding this comment.
ok, thanks for testing
There was a problem hiding this comment.
I added:
howManyProcessesToShow := numberOfRequestedProcessesif len(processes) < howManyProcessesToShow { howManyProcessesToShow = len(processes) }
5aa7e92 to
c3f28ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #35.
It enables user to specify the number of top memory consuming processes to be displayed.
