Replace request with isomorphic-unfetch #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JsonKim
force-pushed
the
isomorphic-unfetch
branch
from
2e98a77
to
01d4e05
Compare
|
@JsonKim This is a very important change! Thank you very much! I'm not familiar with |
|
@JsonKim @Alan-Cha I guess one starting point is to look at the list of alternative libraries that the request team itself compiled: request/request#3143 |
|
@ErikWittern Thanks! @Alan-Cha https://github.com/developit/unfetch is lighter and simpler than other alternatives. And it can be used in both server-side and client-side because it supports polyfill. If you suggest another alternative, I can work on that as well. |
Signed-off-by: Jason Kim <[email protected]>
Alan-Cha
force-pushed
the
isomorphic-unfetch
branch
from
01d4e05
to
dc48906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request has been deprecated since Feb 2020. And I want to use openapi-to-graphql on client-side. However, I can't because request uses fs. So I make and open this pr.